fix(interpreter): add depth limit to extglob pattern matching#447
Merged
fix(interpreter): add depth limit to extglob pattern matching#447
Conversation
chaliy
force-pushed
the
claude/fix-409-Y2nIj
branch
2 times, most recently
from
a198056 to
1d6d7d1
Compare
THREAT[TM-DOS-031]: The +(...) and *(...) extglob handlers in match_extglob recursively call glob_match_impl without any depth limit. For each split point in the string, the function recurses with a reconstructed pattern, creating O(n!) time complexity. Add a MAX_GLOB_DEPTH (50) constant and depth parameter to both glob_match_impl and match_extglob. All recursive calls pass depth + 1, and both functions bail early returning false when the limit is exceeded. Closes #409 https://claude.ai/code/session_01WZjYqxm5xMPAEe7FSHJkDy
chaliy
force-pushed
the
claude/fix-409-Y2nIj
branch
from
1d6d7d1 to
99bd196
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Closes #409